On Tue, 15 May 2018 17:03:51 -0600 Ross Zwisler <ross.zwis...@linux.intel.com> wrote:
> On Thu, May 10, 2018 at 03:28:48PM +0200, Igor Mammedov wrote: [...] > > > Also an extra patch to for make check that will test setting 'cap' > > would be nice (an extra testcase in tests/bios-tables-test.c) > > Hmm...I've been looking at this, and it doesn't look like there is any > verification around a lot of the ACPI tables (NFIT, SRAT, etc). as far as I recall NFIT and SRAT are verified against expected template (limited but at least something) Following commits can serve as an example: e0e5c85 test/acpi-test-data: add ACPI tables for dimmpxm test adae91c tests/bios-tables-test: add test cases for DIMM proximity > I've verified my patch by interacting with a guest with various settings - is > this good enough, or do you really want me to test the value (which I think > would just be "do I get out what I put in at the command line") via the unit > test infrastructure? It would be better to add test especially for a new code. The reason for it is to catch regressions down the road, it also makes easier for maintainer to review/test series. > Thank you for the review. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
