On Mon, Jul 2, 2018 at 4:39 PM, Dave Jiang <dave.ji...@intel.com> wrote: > Adding command definition for security commands defined in Intel DSM > specification v1.7. This includes "get security state", "set passphrase", > "unlock unit", "freeze lock", "secure erase", "ovewrite", and > "overwrite query". Since we are adding a lot of Intel definitions, moving > the relevant bits to its own header. Also, we don't want those commands > to be issued from user space through ioctls. Reason being some of the > security commands require kernel involvement to flush all CPU caches that > can't be done in userspace and the result can cause system crash. So > blocking security commands in the ioctl path. > > Signed-off-by: Dave Jiang <dave.ji...@intel.com> > ---
Looks good, one nit. [..] > diff --git a/drivers/acpi/nfit/nfit.h b/drivers/acpi/nfit/nfit.h > index 7d15856a739f..3b3f59828632 100644 > --- a/drivers/acpi/nfit/nfit.h > +++ b/drivers/acpi/nfit/nfit.h > @@ -20,6 +20,7 @@ > #include <linux/types.h> > #include <linux/acpi.h> > #include <acpi/acuuid.h> > +#include "intel.h" Since nothing in nfit.h requires intel.h this include should move to core.c directly. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
