RE: [ndctl PATCH 1/2] ndctl, monitor: fix the severity of the "daemon started" message

[Qi, Fuli]

> > > >
> > >
> > > Sounds good to me.
> >
> > In my original idea, I just wanted to log the "daemon started" message.
> > After thinking more about it, I agree that the message is not at "error" 
> > level.
> > However, considering this message will be helpful for some users like system
> operators,
> > how about changing this message level to "info" and meanwhile changing the
> default log level to "LOG_INFO" as following?
> >
> > diff --git a/ndctl/monitor.c b/ndctl/monitor.c
> > index d29e378..10866b6 100644
> > --- a/ndctl/monitor.c
> > +++ b/ndctl/monitor.c
> > @@ -628,7 +628,7 @@ int cmd_monitor(int argc, const char **argv, void *ctx)
> >         if (monitor.verbose)
> >                 ndctl_set_log_priority((struct ndctl_ctx *)ctx, LOG_DEBUG);
> >         else
> > -               ndctl_set_log_priority((struct ndctl_ctx *)ctx, LOG_NOTICE);
> > +               ndctl_set_log_priority((struct ndctl_ctx *)ctx, LOG_INFO);
> >
> >         rc = read_config_file((struct ndctl_ctx *)ctx, &monitor, &param);
> >         if (rc)
> > @@ -657,7 +657,7 @@ int cmd_monitor(int argc, const char **argv, void *ctx)
> >                 if (!monitor.log || strncmp(monitor.log, "./", 2) == 0)
> >                         ndctl_set_log_fn((struct ndctl_ctx *)ctx, 
> > log_syslog);
> >                 if (daemon(0, 0) != 0) {
> > -                       err((struct ndctl_ctx *)ctx, "daemon start 
> > failed\n");
> > +                       info((struct ndctl_ctx *)ctx, "daemon start 
> > failed\n");
> >                         goto out;
> >                 }
> >                 err((struct ndctl_ctx *)ctx, "ndctl monitor daemon 
> > started\n");
> 
> Yes, this looks good to me. Will you send a proper patch for this, and I
> can replace my patch with yours.
> 
> Thanks,
>       -Vishal
> 

Ok, I will send a patch.

> >
> > Thank you very much,
> > QI Fuli
> > > _______________________________________________
> > > Linux-nvdimm mailing list
> > > Linux-nvdimm@lists.01.org
> > > https://lists.01.org/mailman/listinfo/linux-nvdimm
> >
> >
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm