On Fri, Nov 30, 2018 at 8:33 AM Dan Williams <dan.j.willi...@intel.com> wrote:
>
> On Fri, Nov 30, 2018 at 8:24 AM Matthew Wilcox <wi...@infradead.org> wrote:
> >
> > On Fri, Nov 30, 2018 at 07:54:49AM -0800, Dan Williams wrote:
> > > Looks good to me, although can we make that cookie an actual type? I
> > > think it's mostly ok to pass around (void *) for 'entry' inside of
> > > fs/dax.c, but once an entry leaves that file I'd like it to have an
> > > explicit type to catch people that might accidentally pass a (struct
> > > page *) to the unlock routine.
> >
> > That's a really good idea. Something like this?
> >
> > typedef struct {
> > void *v;
> > } dax_entry_t;
>
> Yes, please.
>
> > I could see us making good use of that within dax.c.
I'm now thinking that this is a nice improvement for 4.21. For 4.20-rc
lets do the localized fix.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
