On Sun, Jan 13, 2019 at 6:19 PM Wei Yang <richardw.y...@linux.intel.com> wrote: > > We allocate nd_set in acpi_nfit_init_interleave_set() and assignn it to > ndr_desc, while the assignment is done twice in this function. > > This patch removes the second assignment. No functional change.
I think it makes more sense to remove the first assignment. Don't let an uninitialized nd_set escape that routine. Either ->nd_set is left NULL or it points to an initialized instance instead of potentially a zeroed one. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm