On Mon, Jan 14, 2019 at 10:49 AM Vishal Verma <vishal.l.ve...@intel.com> wrote: [..] > I see how it can be replaced now. Here is a revised patch 4 that > includes thses conversions: > > 8<---- > > > From 5c19c269dd0037c3f68725e0f721784056172433 Mon Sep 17 00:00:00 2001 > From: Vishal Verma <vishal.l.ve...@intel.com> > Date: Fri, 11 Jan 2019 18:20:31 -0700 > Subject: [ndctl PATCH] ndctl: clean up usage of ndctl_cmd_submit > > It is possible for ndctl_cmd_submit to return a positive number, > indicating a buffer underrun. It is only truly an error if it returns a > negative number. Several places in the library, the ndctl utility, and > in test/ were simply checking for an error with "if (rc)". Fix these to > only error out for negative returns. > > Cc: Dan Williams <dan.j.willi...@intel.com> > Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com>
Looks good to me. For the series: Reviewed-by: Dan Williams <dan.j.willi...@intel.com> _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
