On Fri, Jan 18, 2019 at 1:12 PM Dave Jiang <dave.ji...@intel.com> wrote: > > > > On 1/18/19 1:58 PM, Verma, Vishal L wrote: > > > > On Thu, 2019-01-17 at 19:38 -0700, Dave Jiang wrote: > >> Add command that allows the user to provide the master encryption key name > >> to be installed in the key material directory where ndctl can refer to > >> for later security operations. > >> > >> Signed-off-by: Dave Jiang <dave.ji...@intel.com> > >> --- > >> Documentation/ndctl/Makefile.am | 3 > >> Documentation/ndctl/ndctl-install-encrypt-key.txt | 31 +++++ > >> configure.ac | 3 > >> ndctl/Makefile.am | 4 - > >> ndctl/builtin.h | 1 > >> ndctl/kek.c | 133 > >> +++++++++++++++++++++ > >> ndctl/lib/libndctl.c | 31 +++++ > >> ndctl/lib/libndctl.sym | 1 > >> ndctl/lib/private.h | 1 > >> ndctl/libndctl.h | 1 > >> ndctl/ndctl.c | 1 > >> 11 files changed, 208 insertions(+), 2 deletions(-) > >> create mode 100644 Documentation/ndctl/ndctl-install-encrypt-key.txt > >> create mode 100644 ndctl/kek.c > >> > >> diff --git a/Documentation/ndctl/Makefile.am > >> b/Documentation/ndctl/Makefile.am > >> index a30b139b..7cb7bd6b 100644 > >> --- a/Documentation/ndctl/Makefile.am > >> +++ b/Documentation/ndctl/Makefile.am > >> @@ -47,7 +47,8 @@ man1_MANS = \ > >> ndctl-inject-smart.1 \ > >> ndctl-update-firmware.1 \ > >> ndctl-list.1 \ > >> - ndctl-monitor.1 > >> + ndctl-monitor.1 \ > >> + ndctl-install-encrypt-key.1 > > > > I think Dan's feedback was to call this command setup-passphrase? > > By 'install-encrypt-key' it seems unclear whether you mean "install > > encrypted key" vs. "install a key and encrypt it" > > Alternatively, the command can simply be 'install-kek', and the > > synopsis/description can expand on what 'kek' is and how it is used. > > It probably should be called install encrypted key or install encryption > key. The next patch has setup-passphrase. This isn't it.
True, but is it more: configure-key than install-key? All we're doing at this point is recording the key details into a configuration file. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
