> From: Vishal Verma <vishal.l.ve...@intel.com>
> Sent: Tuesday, February 26, 2019 3:14 PM
> ...
> diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> @@ -555,16 +555,21 @@ static int btt_freelist_init(struct arena_info *arena)
> if (new < 0)
> return new;
>
> + /* old and new map entries with any flags stripped out */
> + log_oldmap = ent_lba(le32_to_cpu(log_new.old_map));
> + log_newmap = ent_lba(le32_to_cpu(log_new.new_map));
> +
> /* sub points to the next one to be overwritten */
> arena->freelist[i].sub = 1 - new;
> arena->freelist[i].seq = nd_inc_seq(le32_to_cpu(log_new.seq));
> - arena->freelist[i].block = le32_to_cpu(log_new.old_map);
> + arena->freelist[i].block = log_oldmap;
>
> /*
> * FIXME: if error clearing fails during init, we want to make
> * the BTT read-only
> */
> if (ent_e_flag(log_new.old_map)) {
> + set_e_flag(arena->freelist[i].block);
Hi Vishal,
The logic doesn't look quite right to me: as I understand, if both the zero
flag and
the error flag are set, it means a normal map entry rather than an error.
Windows can indeed set both flags:
[ 3.756239] freelist_init: i=0, log_old: lba=bcc01, old_map=c00bcc30,
new_map=c00bcc02, seq=2
[ 3.765583] freelist_init: i=0, log_new: lba=bcc00, old_map=c0001b7b,
new_map=c00bcc30, seq=3
(For the full log, see
https://github.com/dcui/linux/commit/b472968e01d72be3bd42e4568befc4602f9ac396 )
Due to this new line, the 'block' can exceed the normal internal_nlba, and
cause I/O failure:
[ 103.589766] btt_write_pg failed: lane=0x0, new_postmap=0x40001b7b,
internal_nlba=0x1ff8018
[ 103.602387] nd_pmem btt1.1: io error in WRITE sector 33056, len 4096,
[ 103.611662] Buffer I/O error on dev pmem1s2, logical block 36, lost async
page write
I suppose the new line should not be added, and the line
if (ent_e_flag(log_new.old_map)) {
should be changed to
if (ent_e_flag(log_new.old_map) && !
ent_z_flag(log_new.old_map)) {
?
> ret = arena_clear_freelist_error(arena, i);
> if (ret)
> dev_err_ratelimited(to_dev(arena),
Thanks,
-- Dexuan
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
