On Mon, Aug 19, 2019 at 1:26 PM Verma, Vishal L <vishal.l.ve...@intel.com> wrote: > > On Wed, 2019-08-14 at 18:23 -0700, Dan Williams wrote: > > Given the discovery that the original libnvdimm-security implementation > > is unable to communicate both the 'freeze' status and the 'lock' status > > simultaneously, newer kernels deploy a new 'frozen' attribute for this > > purpose. > > > > Add a new api and update the tests for this new capability. The old test > > will fail on newer kernels, but hopefully there were no other > > applications depending on the 'security' attribute to communicate the > > 'freeze' status. It was likely only ever a debug / enumeration aid, not > > an application dependency. > > > > Cc: Dave Jiang <dave.ji...@intel.com> > > Cc: Vishal Verma <vishal.l.ve...@intel.com> > > Reported-by: Jeff Moyer <jmo...@redhat.com> > > Signed-off-by: Dan Williams <dan.j.willi...@intel.com> > > --- > > Documentation/ndctl/ndctl-freeze-security.txt | 8 +++++--- > > ndctl/dimm.c | 2 +- > > ndctl/lib/dimm.c | 25 > > +++++++++++++++++++++++++ > > ndctl/lib/libndctl.sym | 4 ++++ > > ndctl/libndctl.h | 1 + > > test/security.sh | 18 ++++++++++++------ > > util/json.c | 6 ++++++ > > 7 files changed, 54 insertions(+), 10 deletions(-) > > > [..] > > > @@ -262,6 +267,7 @@ test_4_security_unlock > > # not impact any key management testing via libkeyctl. > > echo "Test 5, freeze security" > > test_5_security_freeze > > +exit 1 > > Is this a leftover from local development/testing?
Yes, whoops. Just trying to keep you on your toes. > Otherwise the patch looks good to me. Thanks! Will resend. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
