On Wed, 2019-08-28 at 19:34 -0700, Dan Williams wrote: > On Wed, Aug 28, 2019 at 5:17 PM Vishal Verma <[email protected]> wrote: > > Add a --continue option to ndctl-create-namespaces to allow the creation > > of as many namespaces as possible, that meet the given filter > > restrictions. > > > > The creation loop will be aborted if a failure is encountered at any > > point. > > > > Link: https://github.com/pmem/ndctl/issues/106 > > Reported-by: Steve Scargal <[email protected]> > > Cc: Jeff Moyer <[email protected]> > > Cc: Dan Williams <[email protected]> > > Signed-off-by: Vishal Verma <[email protected]> > > --- > > .../ndctl/ndctl-create-namespace.txt | 7 ++++++ > > ndctl/namespace.c | 25 +++++++++++++++---- > > 2 files changed, 27 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/ndctl/ndctl-create-namespace.txt > > b/Documentation/ndctl/ndctl-create-namespace.txt > > index c9ae27c..55a8581 100644 > > --- a/Documentation/ndctl/ndctl-create-namespace.txt > > +++ b/Documentation/ndctl/ndctl-create-namespace.txt > > @@ -215,6 +215,13 @@ include::xable-region-options.txt[] > > --bus=:: > > include::xable-bus-options.txt[] > > > > +-c:: > > +--continue:: > > + Do not stop after creating one namespace. Instead, greedily create > > as > > I like the "greedy" terminology here because it makes the option seem > a bit off-putting. "Do you really want to be greedy?"
Ha, I just borrowed it from regular expressions :) > > > + many namespaces as possible within the given --bus and --region > > filter > > + restrictions. This will abort if any creation attempt results in an > > + error. > > Hmm, should "--continue --force" override that policy? Yep that's a good idea, with a big note in the man page that errors could be lost/meaningless in that case. > > Otherwise this looks good to me. Thanks, I'll send a new version with the above. _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
