On Wed, Feb 12, 2020 at 6:04 AM Jeff Moyer <[email protected]> wrote: > > Jan Kara <[email protected]> writes: > > > When a kernel is configured without CONFIG_DEV_DAX_PMEM_COMPAT, the > > compilation of tools/testing/nvdimm fails with: > > > > Building modules, stage 2. > > MODPOST 11 modules > > ERROR: "dax_pmem_compat_test" [tools/testing/nvdimm/test/nfit_test.ko] > > undefined! > > > > Fix the problem by calling dax_pmem_compat_test() only if the kernel has > > the required functionality. > > > > Signed-off-by: Jan Kara <[email protected]> > > What's the motivation? Is this just to fix randconfig builds? The > reason I ask is that the test suite will expect to be able to find the > dax_pmem_compat module, so it doesn't make sense to me to disable those > tests only in the kernel as you'll hit a problem when running the tests > anyway.
Yeah, at a minimum you'd also need to go fix up nfit_test_init() to not check for the dax_pmem_compat module: https://github.com/pmem/ndctl/blob/master/test/core.c#L119 > But, I understand if you want to prevent build bots from hitting > compilation failures due to this. Hmm, build bots would only hit what's covered by CONFIG_NVDIMM_TEST_BUILD, and that's only building tools/testing/nvdimm/test/iomap.c. Jan, were you just looking to use nfit_test outside of running the ndctl test suites? Or was this just a drive-by compilation test? _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
