Add support for reporting DIMM health and shutdown state by issuing
PAPR_PDSM_HEALTH request to papr_scm module. It returns an
instance of 'struct nd_papr_pdsm_health' as defined in
'papr_pdsm.h'. The patch provides support for dimm-ops
'new_smart', 'smart_get_health' & 'smart_get_shutdown_state' as newly
introduced functions papr_new_smart_health(), papr_smart_get_health()
& papr_smart_get_shutdown_state() respectively. These callbacks should
enable ndctl to report DIMM health.
Signed-off-by: Vaibhav Jain <vaib...@linux.ibm.com>
---
Changelog:
v5..v6:
* Updated patch description to reflect removal of
update_dimm_health().
* Update papr_smart_get_flags() to parse the 'struct ndctl_cmd'
instance and return appropriate ND_SMART_XXX flags.
* Callbacks papr_smart_get_health() , papr_smart_get_shutdown_state()
callbacks to use 'struct ndctl_cmd' instead of 'dimm_priv'.
* Added update_dimm_flags() to update 'struct ndctl_dimm' with the
flags returned in 'struct nd_papr_psdm_health'.
v4..v5:
* Updated patch description to reflect updated names of struct and
defines that have the term 'scm' removed.
v3..v4:
* None
v2..v3:
* None
v1..v2:
* Squashed patch to report nvdimm bad shutdown state with this patch.
* Switched to new structs/enums as defined in papr_scm_pdsm.h
---
ndctl/lib/papr.c | 73 +++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 72 insertions(+), 1 deletion(-)
diff --git a/ndctl/lib/papr.c b/ndctl/lib/papr.c
index aff294823e41..e1acc3c44295 100644
--- a/ndctl/lib/papr.c
+++ b/ndctl/lib/papr.c
@@ -118,10 +118,23 @@ static struct ndctl_cmd *allocate_cmd(struct ndctl_dimm
*dimm,
return cmd;
}
+/* Parse the nd_papr_pdsm_health and update dimm flags */
+static int update_dimm_flags(struct ndctl_dimm *dimm, struct
nd_papr_pdsm_health *health)
+{
+ /* Update the dimm flags */
+ dimm->flags.f_arm = health->dimm_unarmed;
+ dimm->flags.f_flush = health->dimm_bad_shutdown;
+ dimm->flags.f_restore = health->dimm_bad_restore;
+ dimm->flags.f_smart = (health->dimm_health != 0);
+
+ return 0;
+}
+
/* Validate the ndctl_cmd and return applicable flags */
static unsigned int papr_smart_get_flags(struct ndctl_cmd *cmd)
{
struct nd_pkg_pdsm *pcmd;
+ struct nd_papr_pdsm_health health;
if (!cmd_is_valid(cmd))
return 0;
@@ -134,14 +147,72 @@ static unsigned int papr_smart_get_flags(struct ndctl_cmd
*cmd)
return 0;
}
- /* return empty flags for now */
+ /*
+ * In case of nvdimm health PDSM, update dimm flags
+ * and return possible flags.
+ */
+ if (to_pdsm_cmd(cmd) == PAPR_PDSM_HEALTH) {
+ health = pcmd->payload.health;
+ update_dimm_flags(cmd->dimm, &health);
+ return ND_SMART_HEALTH_VALID | ND_SMART_SHUTDOWN_VALID;
+ }
+
+ /* Else return empty flags */
return 0;
}
+static struct ndctl_cmd *papr_new_smart_health(struct ndctl_dimm *dimm)
+{
+ struct ndctl_cmd *cmd;
+
+ cmd = allocate_cmd(dimm, PAPR_PDSM_HEALTH,
+ sizeof(struct nd_papr_pdsm_health));
+ if (!cmd)
+ papr_err(dimm, "Unable to allocate smart_health command\n");
+
+ return cmd;
+}
+
+static unsigned int papr_smart_get_health(struct ndctl_cmd *cmd)
+{
+ struct nd_papr_pdsm_health health;
+
+ /* Ignore in case of error or invalid pdsm */
+ if (!cmd_is_valid(cmd) ||
+ to_pdsm(cmd)->cmd_status != 0 ||
+ to_pdsm_cmd(cmd) != PAPR_PDSM_HEALTH)
+ return 0;
+
+ /* get the payload from command */
+ health = to_payload(cmd)->health;
+
+ /* Use some math to return one of defined ND_SMART_*_HEALTH values */
+ return !health.dimm_health ? 0 : 1 << (health.dimm_health - 1);
+}
+
+static unsigned int papr_smart_get_shutdown_state(struct ndctl_cmd *cmd)
+{
+ struct nd_papr_pdsm_health health;
+
+ /* Ignore in case of error or invalid pdsm */
+ if (!cmd_is_valid(cmd) ||
+ to_pdsm(cmd)->cmd_status != 0 ||
+ to_pdsm_cmd(cmd) != PAPR_PDSM_HEALTH)
+ return 0;
+
+ /* get the payload from command */
+ health = to_payload(cmd)->health;
+
+ /* return the bad shutdown flag returned from papr_scm */
+ return health.dimm_bad_shutdown;
+}
struct ndctl_dimm_ops * const papr_dimm_ops = &(struct ndctl_dimm_ops) {
.cmd_is_supported = papr_cmd_is_supported,
.smart_get_flags = papr_smart_get_flags,
.get_firmware_status = papr_get_firmware_status,
.xlat_firmware_status = papr_xlat_firmware_status,
+ .new_smart = papr_new_smart_health,
+ .smart_get_health = papr_smart_get_health,
+ .smart_get_shutdown_state = papr_smart_get_shutdown_state,
};
--
2.26.2
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
