On Wed, 13 Jan 2021 16:43:32 -0800 Dan Williams <dan.j.willi...@intel.com> wrote:
> The conversion to move pfn_to_online_page() internal to > soft_offline_page() missed that the get_user_pages() reference taken by > the madvise() path needs to be dropped when pfn_to_online_page() fails. > Note the direct sysfs-path to soft_offline_page() does not perform a > get_user_pages() lookup. > > When soft_offline_page() is handed a pfn_valid() && > !pfn_to_online_page() pfn the kernel hangs at dax-device shutdown due to > a leaked reference. > > Fixes: feec24a6139d ("mm, soft-offline: convert parameter to pfn") > Cc: Andrew Morton <a...@linux-foundation.org> > Cc: Naoya Horiguchi <nao.horigu...@gmail.com> > Cc: Michal Hocko <mho...@kernel.org> > Reviewed-by: David Hildenbrand <da...@redhat.com> > Reviewed-by: Oscar Salvador <osalva...@suse.de> > Cc: <sta...@vger.kernel.org> > Signed-off-by: Dan Williams <dan.j.willi...@intel.com> A cc:stable patch in the middle is awkward. I'll make this a standalone patch for merging into mainline soon (for 5.11) and shall turn the rest into a 4-patch series, OK? _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org