On Sat, Feb 20, 2021 at 7:47 PM Ben Widawsky <ben.widaw...@intel.com> wrote: > > On 21-02-20 18:38:36, Dan Williams wrote: > > On Sat, Feb 20, 2021 at 1:57 PM Ben Widawsky <ben.widaw...@intel.com> wrote: > > > > > > When submitting a command for userspace, input and output payload bounce > > > buffers are allocated. For a given command, both input and output > > > buffers may exist and so when allocation of the input buffer fails, the > > > output buffer must be freed. As far as I can tell, userspace can't > > > easily exploit the leak to OOM a machine unless the machine was already > > > near OOM state. > > > > > > This bug was introduced in v5 of the patch and did not exist in prior > > > revisions. > > > > > > > Thanks for the quick turnaround, but I think that speed introduced > > some issues... > > > > > While here, adjust the variable 'j' found in patch review by Konrad. > > > > Please split this pure cleanup to its own patch. The subject says > > "Fixes", but it's only the one fix. > > > > This was intentional. I pinged you internally to just drop it if you don't > like > to combine these kind of things.
Apologies, I've been offline this weekend and missed that. I will point out though that in general I will not change patch contents on the way upstream. The adjusted patch must appear on the mailing list. The new korg support for attaching attestation to patches requires they all be on the list, so even small adjustments need new postings. > It didn't feel worthwhile to introduce a new > patch to change the 'j'. Janitorial patches happen all the time, so I think it's ok. _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
