On 5/5/21 11:34 PM, Dan Williams wrote: > On Thu, Mar 25, 2021 at 4:10 PM Joao Martins <joao.m.mart...@oracle.com> > wrote: >> >> @altmap is stored in a dev_pagemap, but it will be repurposed for >> hotplug memory for storing the memmap in the hotplugged memory[*] and >> reusing the altmap infrastructure to that end. This is to say that >> altmap can't be replaced with a @pgmap as it is going to cover more than >> dev_pagemap backend altmaps. > > I was going to say, just pass the pgmap and lookup the altmap from > pgmap, but Oscar added a use case for altmap independent of pgmap. So > you might refresh this commit message to clarify why passing pgmap by > itself is not sufficient. > Isn't that what I am doing above with that exact paragraph? I even reference his series at the end of commit description :) in [*] > Other than that, looks good. > /me nods _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
- Re: [PATCH v1 04/11] mm/memrema... Joao Martins
- Re: [PATCH v1 04/11] mm/memremap: add ZO... Aneesh Kumar K.V
- Re: [PATCH v1 04/11] mm/memremap: a... Joao Martins
- [PATCH v1 03/11] mm/page_alloc: refactor memmap_init_zone... Joao Martins
- Re: [PATCH v1 03/11] mm/page_alloc: refactor memmap_... Dan Williams
- Re: [PATCH v1 03/11] mm/page_alloc: refactor mem... Joao Martins
- [PATCH v1 08/11] mm/sparse-vmemmap: use hugepages for PUD... Joao Martins
- [PATCH v1 10/11] device-dax: compound pagemap support Joao Martins
- [PATCH v1 05/11] mm/sparse-vmemmap: add a pgmap argument ... Joao Martins
- Re: [PATCH v1 05/11] mm/sparse-vmemmap: add a pgmap ... Dan Williams
- Re: [PATCH v1 05/11] mm/sparse-vmemmap: add a pg... Joao Martins
- Re: [PATCH v1 05/11] mm/sparse-vmemmap: add ... Dan Williams
- Re: [PATCH v1 05/11] mm/sparse-vmemmap: ... Joao Martins
- [PATCH v1 01/11] memory-failure: fetch compound_head afte... Joao Martins
- Re: [PATCH v1 01/11] memory-failure: fetch compound_... Dan Williams
- Re: [PATCH v1 01/11] memory-failure: fetch compo... Joao Martins
- [PATCH v1 02/11] mm/page_alloc: split prep_compound_page ... Joao Martins
- Re: [PATCH v1 02/11] mm/page_alloc: split prep_compo... Dan Williams
- Re: [PATCH v1 02/11] mm/page_alloc: split prep_c... Joao Martins
- [PATCH v1 11/11] mm/gup: grab head page refcount once for... Joao Martins
- Re: [PATCH v1 00/11] mm, sparse-vmemmap: Introduce compou... Joao Martins