Hi Vaibhav, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on powerpc/next] [also build test WARNING on v5.12 next-20210505] [cannot apply to scottwood/next mpe/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Vaibhav-Jain/powerpc-papr_scm-Make-perf_stats-invisible-if-perf-stats-unavailable/20210506-031853 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/8e7ce04ec36dea95fad178585b697a9c5b5c259d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Vaibhav-Jain/powerpc-papr_scm-Make-perf_stats-invisible-if-perf-stats-unavailable/20210506-031853 git checkout 8e7ce04ec36dea95fad178585b697a9c5b5c259d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All warnings (new ones prefixed by >>): >> arch/powerpc/platforms/pseries/papr_scm.c:903:9: warning: no previous >> prototype for 'papr_nd_attribute_visible' [-Wmissing-prototypes] 903 | umode_t papr_nd_attribute_visible(struct kobject *kobj, struct attribute *attr, | ^~~~~~~~~~~~~~~~~~~~~~~~~ vim +/papr_nd_attribute_visible +903 arch/powerpc/platforms/pseries/papr_scm.c 902 > 903 umode_t papr_nd_attribute_visible(struct kobject *kobj, struct > attribute *attr, 904 int n) 905 { 906 struct device *dev = container_of(kobj, typeof(*dev), kobj); 907 struct nvdimm *nvdimm = to_nvdimm(dev); 908 struct papr_scm_priv *p = nvdimm_provider_data(nvdimm); 909 910 /* For if perf-stats not available remove perf_stats sysfs */ 911 if (attr == &dev_attr_perf_stats.attr && p->stat_buffer_len == 0) 912 return 0; 913 914 return attr->mode; 915 } 916 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
