On Mon, Sep 08, 2008 at 09:02:56PM +0100, ext Måns Rullgård wrote:
> "arun c" <[EMAIL PROTECTED]> writes:
> > +   while (dispc_read_reg(DISPC_CONTROL) & (1 << 5))
> > +           continue;
> > +   MOD_REG_FLD(DISPC_CONTROL, 1 << 5, 1 << 5);
> > +
> >     return height * screen_width * bpp / 8;
> >  }
> 
> This looks good.  However, the same thing is needed in
> omap_dispc_enable_plane() as well.  Placing the loop+set in a function
> (go_lcd()?) would make sense.

Preferably something with a slightly more generic name, so it could
also fire GODIGITAL for digital out, when support for that exists.

Cheers,
Daniel

Attachment: signature.asc
Description: Digital signature

Reply via email to