On Thursday 11 September 2008, Singh, Vimal wrote:
> I will define NAND_BLOCK_SIZE as:
> #define NAND_BLOCK_SIZE                64 * NAND_MAX_PAGESIZE

Never define such things without parentheses ...

Also, that looks wrong as well as sub-optimal.  Current NAND chips
can have page sizes up to 4 KB (right?), so I think "MAX" isn't
what you would want (even if it never grows again).

I'd just use SZ_128K for NAND_BLOCK_SIZE, and avoid the confusion.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to