On Fri, Oct 10, 2008 at 06:39:03PM +0530, ext Premi, Sanjeev wrote: > > > > -----Original Message----- > > From: Felipe Balbi [mailto:[EMAIL PROTECTED] > > Sent: Friday, October 10, 2008 6:24 PM > > To: ext Felipe Balbi > > Cc: Premi, Sanjeev; linux-omap@vger.kernel.org; Paul Walmsley > > Subject: Re: [PATCH] Fix compiler warnings in smartreflex.c > > > > On Fri, Oct 10, 2008 at 03:44:07PM +0300, ext Felipe Balbi wrote: > > > On Fri, Oct 10, 2008 at 06:07:17PM +0530, ext Sanjeev Premi wrote: > > > > Fix these compiler warnings: > > > > smartreflex.c:126: warning: initialization makes integer from > > > > pointer without a cast > > > > smartreflex.c:134: warning: initialization makes integer from > > > > pointer without a cast > > > > > > > > Signed-off-by: Sanjeev Premi <[EMAIL PROTECTED]> > > > > --- > > > > arch/arm/mach-omap2/smartreflex.c | 4 ++-- > > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/arch/arm/mach-omap2/smartreflex.c > > > > b/arch/arm/mach-omap2/smartreflex.c > > > > index e54c0fb..8460633 100644 > > > > --- a/arch/arm/mach-omap2/smartreflex.c > > > > +++ b/arch/arm/mach-omap2/smartreflex.c > > > > @@ -123,7 +123,7 @@ static struct omap_sr sr1 = { > > > > .is_sr_reset = 1, > > > > .is_autocomp_active = 0, > > > > .clk_length = 0, > > > > - .srbase_addr = OMAP2_IO_ADDRESS(OMAP34XX_SR1_BASE), > > > > + .srbase_addr = > > (u32)OMAP2_IO_ADDRESS(OMAP34XX_SR1_BASE), > > > > > > please don't. Most likely srbase_addr should move to void __iomem * > > > > > > Paul, any comments ?? > > > > Took a look at it, the following might be a better ?? (compile tested > > only) > > Looks good. I will try on my evm immediately.
please do it. Try it out and resend with you proper signed-off-by line ;-) You should probably put those whitespace cleanups in a separate patch. Also, please Cc Kevin when you resend :-D -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
