On to, 2008-11-20 at 19:43 +0530, ext Premi, Sanjeev wrote:
>
>
> > -----Original Message-----
> > From: [EMAIL PROTECTED]
> > [mailto:[EMAIL PROTECTED] On Behalf Of Peter Reid
> > Sent: Thursday, November 20, 2008 2:16 PM
> > To: Kevin Hilman
> > Cc: linux-omap@vger.kernel.org
> > Subject: Re: [ANNOUNCE] new PM branch: pm-20081119
> >
> > Hello kevin,
> > Here is what i did to put it to suspend, which fails.
> >
> > [EMAIL PROTECTED] echo mem > /sys/power/state
> > PM: Syncing filesystems ... done.
> > Freezing user space processes ... (elapsed 0.00 seconds) done.
> > Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done.
> > Suspending console(s)
> > Class driver suspend failed for cpu0
> > PM: Some devices failed to power down
> >
> > Regards,
> > Reid.
> These are my observations on OMAP3EVM:
>
> 1) Very frequently I see these messages:
>
> <4>__ratelimit: 6736 callbacks suppressed
> __ratelimit: 6736 callbacks suppressed
> <3>omapfb omapfb: irq error status 00c2
> omapfb omapfb: irq error status 00c2
> <3>omapfb omapfb: irq error status 0060
> omapfb omapfb: irq error status 0060
> <3>omapfb omapfb: irq error status 00c2
> omapfb omapfb: irq error status 00c2
> <3>omapfb omapfb: irq error status 0060
> omapfb omapfb: irq error status 0060
> <3>omapfb omapfb: irq error status 00e2
> omapfb omapfb: irq error status 00e2
> <3>omapfb omapfb: irq error status 00c2
> omapfb omapfb: irq error status 00c2
> <3>omapfb omapfb: irq error status 0060
> omapfb omapfb: irq error status 0060
> <3>omapfb omapfb: irq error status 00e2
> omapfb omapfb: irq error status 00e2
> <3>omapfb omapfb: irq error status 00c2
> omapfb omapfb: irq error status 00c2
> <3>omapfb omapfb: irq error status 0060
> omapfb omapfb: irq error status 0060
The interrupts we see here mean that GFX FIFO has underflown. This is
because cpu idle issues WFI very frequently making the DSS also stop
it's clocks when idle. Problem is that waking up the DSS seems to take
longer than the FIFO lasts.
You can fix this by setting the fifo thresholds to very high. TI uses
1020 for high thresholds and 956 for low thresholds in their kernel.
Maximum is 1023.
Here's a patch by Imre, that worked for us.
- Kalle
>From d23ce521f95671f1b012b8542e88100d4a143771 Mon Sep 17 00:00:00 2001
From: Imre Deak <[EMAIL PROTECTED]>
Date: Tue, 11 Nov 2008 13:43:39 +0200
Subject: [PATCH] ARM: OMAP: OMAPFB: Adjust DMA FIFO thresholds for power
save mode
DMA FIFO underflow error occures if power save mode is enabled, try
to tackle this by setting a higher DMA FIFO threshold values. Also
the maximum value is FIFO size - 1 not FIFO size, so fix this.
Problem report and solution from Kalle Jokiniemi.
Signed-off-by: Imre Deak <[EMAIL PROTECTED]>
---
drivers/video/omap/dispc.c | 13 ++++---------
1 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/video/omap/dispc.c b/drivers/video/omap/dispc.c
index da827b1..b4a1542 100644
--- a/drivers/video/omap/dispc.c
+++ b/drivers/video/omap/dispc.c
@@ -296,15 +296,10 @@ static void setup_plane_fifo(int plane, int
ext_mode)
BUG_ON(plane > 2);
l = dispc_read_reg(fsz_reg[plane]);
- l &= FLD_MASK(0, 11);
- if (ext_mode) {
- low = l * 3 / 4;
- high = l;
- } else {
- low = l / 4;
- high = l * 3 / 4;
- }
- MOD_REG_FLD(ftrs_reg[plane], FLD_MASK(16, 12) | FLD_MASK(0, 12),
+ l &= FLD_MASK(0, 9);
+ low = l * 3 / 4;
+ high = l - 1;
+ MOD_REG_FLD(ftrs_reg[plane], FLD_MASK(16, 9) | FLD_MASK(0, 9),
(high << 16) | low);
}
--
1.5.4.3
>
> 2) Also:
> # echo mem > /sys/power/state
> <6>PM: Syncing filesystems ...
> PM: Syncing filesystems ...
> done.
> done.
> Freezing user space processes ... Freezing user space processes ... (elapsed
> 0.00 seconds) (elapsed 0.00 seconds) done.
> done.
> Freezing remaining freezable tasks ... Freezing remaining freezable tasks ...
> (elapsed 0.00 seconds) (elapsed 0.00 seconds) done.
> done.
>
> Suspending console(s) (use no_console_suspend to debug)
> Suspending console(s) (use no_console_suspend to debug)
> <3>omapfb omapfb: timeout waiting for FRAME DONE
>
> However, I the "resume" doesn't happen.
> Trying to debug further.
>
> Best regards,
> Sanjeev
>
> > On Thu, Nov 20, 2008 at 6:23 AM, Kevin Hilman
> > <[EMAIL PROTECTED]> wrote:
> > > Hello,
> > >
> > > A new PM branch is available named pm-20081119.
> > >
> > > This is mostly a new set of patches on top of the previous
> > PM branch,
> > > rather than a rebase. We finally found the root cause of some DPLL
> > > relocking bugs. Special thanks to Paul Walmsley and Tero
> > Kristo for
> > > debugging and fixing this problem. Now the DPLL fix that
> > was reverted
> > > in the previous PM branch is re-applied as well as some
> > fixes on top
> > > of it. It also has some additional UART fixes, so I think the UART
> > > idle work is ready to go to Tony. Special thanks to Jouni Hogander
> > > for the extra testing and fixes here.
> > >
> > > The shortlog is below[1] and the root of the tree is still
> > > v2.6.27-omap1 + T2 power patches from Peter.
> > >
> > > This has primarily been tested on custom HW since I'm
> > _still_ waiting
> > > for my SDP to arrive. I have boot tested on Beagle, but I
> > think there
> > > are still some problems with ES2 silicon. On my ES2
> > Beagle, neither
> > > DSS or IVA will leave the ON state, even when all clocks in their
> > > powerdomains are off. I have not debugged this further yet.
> > >
> > > Functionally, this tree is in pretty good shape, so I will do some
> > > bugfixes here when necessary, but will now spent some time
> > focusing on
> > > getting the patches in this branch merged into linux-omap.
> > >
> > > Kevin
> > >
> > >
> > > [1] git shortlog:
> > >
> > > Amit Kucheria (2):
> > > OMAP: PM: Typo fix for clock_allow_idle
> > > HSMMC: Make driver support dynamic idle
> > >
> > > Jouni Hogander (11):
> > > OMAP3: PM: Use pwrdm_set_next_pwrst instead of
> > set_pwrdm_state in idle loop
> > > OMAP3: Do not set mpu, core, neon states if cpuidle is used
> > > OMAP3: PM: Do not set next states sw to control those
> > is available
> > > OMAP3: PM: Always return value in pwrdms_setup
> > > OMAP3: PM: Fix wrong sequence in suspend.
> > > OMAP3: UART: Make sure that uart clocks are enabled when needed
> > > OMAP3: PM: Check in set_pwrdm_state that target state
> > is supported by pwrdm v2
> > > OMAP3: PM: Do not build suspend code if SUSPEND is not enabled
> > > OMAP: PM: Build fails if PM is not enabled
> > > OMAP2: PM: Fix omap2 build
> > > OMAP: MCSPI: Enable mcspi wake-up
> > >
> > > Kalle Jokiniemi (4):
> > > OMAP: PM: sysfs interface for enabling voltage off in idle
> > > OMAP3: PM: Fix cpu idle init sequencing
> > > OMAP: SRF: Fixes to shared resource framework (Ver.3)
> > > OMAP3: I2C: Enable I2C wakeups
> > >
> > > Kevin Hilman (16):
> > > OMAP3: PM: Add wake-up bit defintiions for CONTROL_PADCONF_X
> > > OMAP3: PM: Allow UARTs to be unclocked when inactive
> > > 8250: Allow platform to register PM hook
> > > 8250: when waking, PM hook should be called before
> > accessing port
> > > OMAP3: PM: UART: Add 8250 UART PM hook for suspend/resume
> > > OMAP3: PM: UART save/restore support for OFF-mode
> > > OMAP2/3: HSMMC: Ensure HSMMC is fully reset on boot
> > > OMAP3: PM: CPUidle: obey enable_off_mode flag
> > > OMAP3: PM: CPUidle: restrict C-states on UART activity
> > > OMAP3: PM: decouple PER and CORE context save and restore
> > > Revert "OMAP3 clock: fix non-CORE DPLL rate assignment bugs"
> > > Revert "OMAP3: PM: Do not set next states sw to
> > control those is available"
> > > Revert "OMAP3: Do not set mpu, core, neon states if
> > cpuidle is used"
> > > OMAP: PM: UART: fix can_sleep hook to return correct value
> > > OMAP: PM: UART: Only disable clocks in prepare-idle hook
> > > OMAP3: PM: Check for UART wakeups in 'resume_idle' hook
> > >
> > > Paul Walmsley (14):
> > > OMAP2/3 PM: create the OMAP PM interface and add a
> > default OMAP PM no-op layer.
> > > OMAP2/3 omapdev: add basic omapdev structure
> > > OMAP242x omapdev: add OMAP242x omapdev records
> > > OMAP243x omapdev: add OMAP243x omapdev records
> > > OMAP3xxx omapdev: add OMAP3xxx omapdev records
> > > OMAP2/3 omapdev: add code to walk the omapdev records
> > > OMAP3 clock: fix non-CORE DPLL rate assignment bugs
> > > OMAP3 powerdomains: remove RET from SGX power states list
> > > OMAP3 powerdomains: remove RET from SGX power states list
> > > OMAP3 clock: remove unnecessary dpll_data dereferences
> > > OMAP3 clock: optimize DPLL rate rounding algorithm
> > > OMAP3 clock: avoid invalid FREQSEL values during DPLL
> > rate rounding
> > > OMAP2/3 I2C: reprogram OCP_SYSCONFIG register after reset
> > > OMAP: I2C: convert 'rev1' flag to generic 'rev' u8
> > >
> > > Peter 'p2' De Schrijver (9):
> > > OMAP: PM counter infrastructure.
> > > OMAP: PM: Hook into PM counters
> > > OMAP: PM: Add closures to clkdm_for_each and pwrdm_for_each.
> > > OMAP: PM: Add pm-debug counters
> > > OMAP: PM debug: make powerdomains use PM-debug counters
> > > OMAP: PM: Add definitions for ETK pads and
> > observability registers
> > > OMAP: Debug observability and ETK padconf implementation
> > > OMAP: Add debug observablity (debobs) Kconfig item
> > > OMAP: PM: Implement get_last_off_on_transaction_id()
> > >
> > > Rajendra Nayak (23):
> > > OMAP3: PM: GPMC context save/restore
> > > OMAP3: PM: GPIO context save/restore
> > > OMAP3: PM: I2C context save/restore
> > > OMAP3: PM: INTC context save/restore
> > > OMAP3: PM: PRCM context save/restore
> > > OMAP3: PM: Populate scratchpad contents
> > > OMAP3: PM: SCM context save/restore
> > > OMAP3: PM: SRAM restore function
> > > OMAP3: PM: handle PER/NEON/CORE in idle
> > > OMAP3: PM: Restore MMU table entry
> > > OMAP3: PM: MPU off-mode support
> > > OMAP3: PM: CORE domain off-mode support
> > > OMAP3: PM: allow runtime enable/disable of OFF mode
> > > OMAP3: 3430SDP minimal kernel defconfig
> > > OMAP3: PM: CPUidle: Basic support for C1-C2
> > > OMAP3: PM: CPUidle: Enables state C4
> > > OMAP3: PM: CPUidle: Enables C3 and C5
> > > OMAP3: PM: CPUidle: Safe-state on bm-activity
> > > OMAP3: PM: CPUidle: Enable Kconfig option for OMAP
> > > OMAP3 SRF: Generic shared resource f/w
> > > OMAP3 SRF: MPU/CORE/PD latency modeling
> > > OMAP3 SRF: omap3 srf driver
> > > OMAP3 SRF: OMAP PM srf implementation
> > >
> > > Tero Kristo (13):
> > > OMAP: PM debug: do not print out status for meta
> > powerdomains (dpll*)
> > > OMAP: PM debug: Add PRCM register dump support
> > > OMAP: PM: DMA context save / restore
> > > OMAP: PM: off-mode support for DMA on EMU/HS devices
> > > OMAP3: SRAM size fix for HS/EMU devices
> > > OMAP3 PM: off-mode support for HS/EMU devices
> > > OMAP3: PM: Enable SDRAM auto-refresh during sleep
> > > OMAP: SDRC: Add new register definitions for SDRAM controller
> > > OMAP3: PM: SDRC auto-refresh workaround for off-mode
> > > PM: Fix a bug with noncore dpll rate calculation
> > > PM: Added three PLL registers to the PRCM context save
> > > PM: OMAP3: Make sure clk_disable_unused() order is correct
> > > PM: Changed secure RAM storage size from 0x8000 to 0x803F
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe
> > linux-omap"
> > > in the body of a message to [EMAIL PROTECTED] More
> > majordomo
> > > info at http://vger.kernel.org/majordomo-info.html
> > >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-omap" in the body of a message to
> > [EMAIL PROTECTED] More majordomo info at
> > http://vger.kernel.org/majordomo-info.html
> >
> > --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
