* Kevin Hilman <[EMAIL PROTECTED]> [081126 10:39]: > "Woodruff, Richard" <[EMAIL PROTECTED]> writes: > > >> * Woodruff, Richard <[EMAIL PROTECTED]> [081014 12:47]: > >> > > omap_dm_timer_write_reg(timer, OMAP_TIMER_COUNTER_REG, load); > >> > > - omap_dm_timer_write_reg(timer, OMAP_TIMER_LOAD_REG, load); > >> > > omap_dm_timer_write_reg(timer, OMAP_TIMER_CTRL_REG, l); > >> > > } > >> > > >> > I seem to recall there was a missed interrupt condition which this worked > >> around. > >> > > >> > IIRC, the original code didn't bother with the load I added back as a > >> > work > >> around as a way to get posted mode working. > >> > >> Well these seem to be working based on some quick timer tests. > >> Pushing so we can verify it ;) > > > > This kind of change might be better tested on the PM branch. It's > > the kind of thing more likely to work with PM disabled. Testing in > > both is good, PM for many things is less forgiving... > > I validated these patches on the PM branch. > > I used cyclictest to test lots of timer reprogramming, and also tested > in both RET-while-idle and OFF-while-idle for low frequency timer > reprogramming. > > Acked-by: Kevin Hilman <[EMAIL PROTECTED]>
Thanks for testing, pushing them to l-o today and adding to omap2-upstream queue. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
