On Tue, 2009-02-10 at 11:52 -0800, David Brownell wrote: > On Tuesday 10 February 2009, Kalle Jokiniemi wrote: > > > This patch disables LDO regulators VUSB1V5, VUSB1V8, and VUSB3V1 > > > when the USB cable is unplugged, to eliminate that source of power > > > waste. (Enabled LDOs consume power at all times.) > > > > Please put this on hold for a while. This won't work if we don't have > > TWL regulator support enabled. > > So Kconfig should have TWL4030_USB depend on REGULATOR_TWL4030?
Yes. > > > > Also it's missing error value checking. > > You mean like in the ldo_init() stuff? Fair enough. I mean, if regulator_get fails. - Kalle > > - Dave > > > > I'll post new patch(es) soon. > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
