From: ext Russell King - ARM Linux <li...@arm.linux.org.uk>
Subject: Re: [PATCH 3/6] omap iommu: omap3 iommu device registration
Date: Sat, 16 May 2009 11:55:14 +0200

> On Sat, May 16, 2009 at 10:20:36AM +0100, Russell King - ARM Linux wrote:
> > This looks all very convoluted.  Why not do something like:
> > 
> > static unsigned long iommu_base[] = {
> >     OMAP3_MMU1_BASE,
> >     OMAP3_MMU2_BASE,
> > };
> > 
> > static int iommu_irq[] = {
> >     OMAP3_MMU1_IRQ,
> >     OMAP3_MMU2_IRQ,
> > };
> 
> BTW, both of these can be __initdata.

OK, I'll send the update ones. Thank you for reviewing them.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to