>-----Original Message----- >From: linux-omap-ow...@vger.kernel.org >[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of >Nishanth Menon >Sent: Thursday, August 13, 2009 11:31 AM >To: Kevin Hilman >Cc: Premi, Sanjeev; linux-omap@vger.kernel.org >Subject: Re: [PATCH] Runtime detection of Si features > >Kevin Hilman had written, on 08/13/2009 11:13 AM, the following: >> Sanjeev Premi <pr...@ti.com> writes: >> >>> The OMAP35x family has multiple variants differing >>> in the HW features. This patch detects these features >>> at runtime and prints information during the boot. >>> >>> Since most of the code seemed repetitive, macros >>> have been used for readability. >>> >>> Signed-off-by: Sanjeev Premi <pr...@ti.com> >> >> I like the feature-based approach. >> >> A couple questions though. Is there a bit/register that reports the >> collapsed powerdomains of the devices with modified PRCM? >> >> Also, how will other code query the features? You're currently >> exporting the omap_has_*() functions, but there are no prototypes. >> >> I think I'd rather see a static inline functions in <mach/cpu.h> >> for checking features. Comments to that end inlined below... >Wonder if we can setup some sort of infrastructure for: >a) features >b) erratas >linked to OMAP revs + even better w.r.t silicon module(SGX,I2c) >revisions since at times they are used across multiple OMAPs?
We are hitting exactly this issue with I2C errata 1.153 Instead of basing the errata check on cpu_is...(), its more appropriate to base it on IP revision of I2C. > >-- >Regards, >Nishanth Menon >-- >To unsubscribe from this list: send the line "unsubscribe linux-omap" in >the body of a message to majord...@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
