Romit Dasgupta wrote:
>> diff --git a/arch/arm/mach-omap2/dspbridge.c
>> b/arch/arm/mach-omap2/dspbridge.c
>> +
>> static int __init dspbridge_init(void)
>> {
>> struct platform_device *pdev;
>> @@ -48,6 +65,10 @@ static int __init dspbridge_init(void)
>> if (!pdev)
>> goto err_out;
>>
>> + err = get_opp_table(pdata);
>> + if (err)
>> + goto err_out;
>> +
>> err = platform_device_add_data(pdev, pdata, sizeof(*pdata));
>> if (err)
>> goto err_out;
>> @@ -60,6 +81,10 @@ static int __init dspbridge_init(void)
>> return 0;
>>
>> err_out:
>> + kfree(pdata->mpu_speeds);
>> + kfree(pdata->dsp_freq_table);
> Are we sure that pdata->dsp_freq_table is NULL before initialization?
> Looking at your second part of the patch. You seem to invoke kfree for
> pdata->dsp_freq_table even if pdata->dsp_freq_table is not allocated.
> So my question is :
missed the last part of the mail. If pdata->dsp_freq_table is NULL to start
with. This is ok. Otherwise this needs to be changed.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
