> -----Original Message----- > From: Felipe Balbi [mailto:m...@felipebalbi.com] > Sent: Monday, March 08, 2010 12:29 PM > To: Aguirre, Sergio > Cc: linux-omap@vger.kernel.org; Kevin Hilman; Pandita, Vikram; Paul > Walmsley; Tony Lindgren > Subject: Re: [RFC part1/2 merge v2 RESEND][PATCH 04/10] OMAP clock: Add > uart4_ick/fck definitions for 3630 > > On Mon, Mar 08, 2010 at 11:28:46AM -0600, Sergio Aguirre wrote: > > @@ -3420,6 +3440,7 @@ static struct omap_clk omap3xxx_clks[] = { > > CLK(NULL, "per_96m_fck", &per_96m_fck, CK_3XXX), > > CLK(NULL, "per_48m_fck", &per_48m_fck, CK_3XXX), > > CLK(NULL, "uart3_fck", &uart3_fck, CK_3XXX), > > + CLK(NULL, "uart4_fck", &uart4_fck, CK_36XX), > > CLK(NULL, "gpt2_fck", &gpt2_fck, CK_3XXX), > > CLK(NULL, "gpt3_fck", &gpt3_fck, CK_3XXX), > > CLK(NULL, "gpt4_fck", &gpt4_fck, CK_3XXX), > > @@ -3443,6 +3464,7 @@ static struct omap_clk omap3xxx_clks[] = { > > CLK(NULL, "gpio2_ick", &gpio2_ick, CK_3XXX), > > CLK(NULL, "wdt3_ick", &wdt3_ick, CK_3XXX), > > CLK(NULL, "uart3_ick", &uart3_ick, CK_3XXX), > > + CLK(NULL, "uart4_ick", &uart4_ick, CK_36XX), > > are the uart clocks shared ? Why not defining the devname here if > they're not ? We would loop less to find the clock that way.
I think I'll better wait for hwmod changes, since seems this could change. (Kevin, correct me if I'm wrong.) Anyways, maybe this needs to be handled by a separate patch, to assign all uart clocks, from 1 to 4, to a specific device. Regards, Sergio > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
