RE: [PATCHv2 0/3] Add support for TCA6416 based Keypad driver.

[Govindarajan, Sriramakrishnan]

> -----Original Message-----
> From: Grazvydas Ignotas [mailto:nota...@gmail.com]
> Sent: Friday, March 12, 2010 4:54 PM
> To: Govindarajan, Sriramakrishnan
> Cc: linux-omap@vger.kernel.org; linux-in...@vger.kernel.org
> Subject: Re: [PATCHv2 0/3] Add support for TCA6416 based Keypad driver.
> 
> On Fri, Mar 12, 2010 at 11:18 AM, Sriramakrishnan <s...@ti.com> wrote:
> > AM3517 EVM with APPS board includes keys interfaced to TCA6416 IO
> expander
> > User keys are connected as GPIO lines to TCA6416 IO expander. Unlike the
> > case with generic gpio-keypad driver individual keys do not generate an
> > interrupt event. Hence we implement a simple keypad driver, that
> > registers as direct I2C client.
> >
> > The implementation has been tested on AM3517 EVM with the driver tested
> > in polling mode.
> >
> > Version2 of the patch series addresses review comments from the earlier
> > posting - specifically redesigned to eliminate overhead of using
> gpio_keys
> > data structures.
> >
> > Sriramakrishnan (3):
> >  TCA6416 keypad : Implement keypad driver for keys interfaced to
> >    TCA6416
> >  AM3517: Board hookup for TCA6416 keypad driver.
> >  AM3517 EVM : Enable TCA6416 keypad.
> >
> >  arch/arm/configs/am3517_evm_defconfig   |   16 ++-
> >  arch/arm/mach-omap2/board-am3517evm.c   |   47 ++++-
> >  drivers/input/keyboard/Kconfig          |   16 ++
> >  drivers/input/keyboard/Makefile         |    1 +
> >  drivers/input/keyboard/tca6416-keypad.c |  354
> +++++++++++++++++++++++++++++++
> >  include/linux/tca6416_keypad.h          |   34 +++
> >  6 files changed, 462 insertions(+), 6 deletions(-)
> >  mode change 100644 => 100755 arch/arm/mach-omap2/board-am3517evm.c
> >  create mode 100755 drivers/input/keyboard/tca6416-keypad.c
> >  create mode 100755 include/linux/tca6416_keypad.h
> 
> Please fix mode - remove +x flags.
[Sriram] Thanks for pointing out. I will await further review comments
And post the updated version thereafter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html