* Sukumar Ghorai <[email protected]> [100512 02:43]:
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -64,16 +64,32 @@ static void __iomem *gpmc_base;
>
> static struct clk *gpmc_l3_clk;
>
> -static void gpmc_write_reg(int idx, u32 val)
> +void gpmc_write_reg(int idx, u32 val)
> {
> __raw_writel(val, gpmc_base + idx);
> }
>
> -static u32 gpmc_read_reg(int idx)
> +u32 gpmc_read_reg(int idx)
> {
> return __raw_readl(gpmc_base + idx);
> }
>
> +void gpmc_cs_write_byte(int cs, int idx, u32 val)
> +{
> + void __iomem *reg_addr;
> +
> + reg_addr = gpmc_base + GPMC_CS0_BASE + (cs * GPMC_CS_SIZE) + idx;
> + __raw_writeb(val, reg_addr);
> +}
> +
> +u8 gpmc_cs_read_byte(int cs, int idx)
> +{
> + void __iomem *reg_addr;
> +
> + reg_addr = gpmc_base + GPMC_CS0_BASE + (cs * GPMC_CS_SIZE) + idx;
> + return __raw_readb(reg_addr);
> +}
> +
This will not improve the situation unfortunately.
We for sure don't want to export functions to mess
with the GPMC registers all over the place.
> @@ -432,15 +448,6 @@ void gpmc_prefetch_reset(void)
> }
> EXPORT_SYMBOL(gpmc_prefetch_reset);
>
> -/**
> - * gpmc_prefetch_status - reads prefetch status of engine
> - */
> -int gpmc_prefetch_status(void)
> -{
> - return gpmc_read_reg(GPMC_PREFETCH_STATUS);
> -}
> -EXPORT_SYMBOL(gpmc_prefetch_status);
> -
And we don't want to remove GPMC functions like this,
instead we need to implement more functions like this
for the platform init code to use.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
