On Mon, May 24, 2010 at 10:29:01PM +0300, Felipe Contreras wrote:
> On Mon, May 24, 2010 at 5:42 PM, Hiroshi DOYU <[email protected]> wrote:
> > From: ext Felipe Contreras <[email protected]>
> 
> >> +     if (false);
> >
> > nitpcik:
> > The above may look better as below:
> >
> >        if (false)
> >                ;
> >
> > "checkpatch.pl" also doesn't complain.
> 
> Personally I think it looks weird and it's a checkpatch bug, but fine by me.

No, I'd say it's intentional.

        if (false);

looks too much like an error - think about:

        if (false);
                do_something();

which would be very easy to miss while reviewing.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to