Hello Tony, I need your comment/input - whether we need an additional file for NAND support in ZOOM2/3?
In current codebase has a board-sdp-flash.c file. I think we can remove "-sdp-" from board-sdp-flash.c and reuse the file for ZOOM boards or any other upcoming board(s). Advantage: a. No need to add any additional file like board-zoom-flash.c b. And the existing board-sdp-flash.c is very small and easily re-use for zoom boards easily. Disadvantage: a. Few additional functions in the same file for NOR and OneNAND is not applicable for zoom. b. rename the file board-sdp-flash.c to board-flash.c c. Remove the static of board_nand_init() and additional one line for zoom board checking. Please let me know your opinion. Regards, Ghorai > -----Original Message----- > From: Ghorai, Sukumar > Sent: Tuesday, April 13, 2010 11:07 PM > To: linux-omap@vger.kernel.org > Cc: Ghorai, Sukumar > Subject: [PATCH] nand support on omap3 boards > > The following set of patches applies on top of the Tony's master > branch. > And these are the patches required to enable nand (nor and onenand for > sdp > only) for different platform. > > Sukumar Ghorai (3): > OMAP: ZOOM: Introducing 'board-zoom-flash.c' > omap3: add support for NAND on zoom2 board > omap3: add support for NAND on zoom3 board > omap-3630-sdp : Add support for Flash > omap-3630-sdp: enable Flash device support > omap3: add support for NAND on LDP board > zoom2: enable NAND support > zoom3: enable NAND support > > arch/arm/configs/omap_3630sdp_defconfig | 77 +++++++++++++++++- > arch/arm/configs/omap_zoom2_defconfig | 90 > ++++++++++++++++++++- > arch/arm/configs/omap_zoom3_defconfig | 90 > ++++++++++++++++++++- > arch/arm/mach-omap2/Makefile | 4 + > arch/arm/mach-omap2/board-3630sdp.c | 110 > +++++++++++++++++++++++++ > arch/arm/mach-omap2/board-ldp.c | 41 +++++++++ > arch/arm/mach-omap2/board-sdp-flash.c | 2 + > arch/arm/mach-omap2/board-zoom-flash.c | 82 ++++++++++++++++++ > arch/arm/mach-omap2/board-zoom2.c | 49 +++++++++++ > arch/arm/mach-omap2/board-zoom3.c | 48 +++++++++++ > arch/arm/mach-omap2/include/mach/board-zoom.h | 11 +++ > 11 files changed, 601 insertions(+), 3 deletions(-) create mode 100644 > arch/arm/mach-omap2/board-zoom-flash.c -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
