Tony,
> -----Original Message-----
> From: Tony Lindgren [mailto:[email protected]]
> Sent: Wednesday, July 07, 2010 3:52 PM
> To: Ghorai, Sukumar
> Cc: [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH v5 2/3] omap3 nand: cleanup virtual address usages
>
> * Sukumar Ghorai <[email protected]> [100604 10:34]:
> > --- a/arch/arm/plat-omap/include/plat/gpmc.h
> > +++ b/arch/arm/plat-omap/include/plat/gpmc.h
> > @@ -63,7 +60,6 @@
> > #define GPMC_CONFIG1_DEVICESIZE_16 GPMC_CONFIG1_DEVICESIZE(1)
> > #define GPMC_CONFIG1_DEVICETYPE(val) ((val & 3) << 10)
> > #define GPMC_CONFIG1_DEVICETYPE_NOR GPMC_CONFIG1_DEVICETYPE(0)
> > -#define GPMC_CONFIG1_DEVICETYPE_NAND GPMC_CONFIG1_DEVICETYPE(2)
> > #define GPMC_CONFIG1_MUXADDDATA (1 << 9)
> > #define GPMC_CONFIG1_TIME_PARA_GRAN (1 << 4)
> > #define GPMC_CONFIG1_FCLK_DIV(val) (val & 3)
>
> Is this no longer needed?
[Ghorai] we pass GPMC_CONFIG_DEV_TYPE and GPMC_DEVICETYPE_NAND to
gpmc_hwcontrol(); And GPMC_DEVICETYPE_NAND define in previous patch of the same
series.
>
> > --- a/arch/arm/plat-omap/include/plat/nand.h
> > +++ b/arch/arm/plat-omap/include/plat/nand.h
> > @@ -21,13 +21,11 @@ struct omap_nand_platform_data {
> > int (*dev_ready)(struct omap_nand_platform_data *);
> > int dma_channel;
> > unsigned long phys_base;
> > - void __iomem *gpmc_cs_baseaddr;
> > - void __iomem *gpmc_baseaddr;
> > int devsize;
> > };
>
> Glad to see these finally going away!
>
> Regards,
>
> Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
