Mark Brown had written, on 08/06/2010 08:32 AM, the following:
On Fri, Aug 06, 2010 at 08:10:44AM -0500, Nishanth Menon wrote:
a) when the strings are split up when they go multiple lines:
E.g.:
"abcd "
"efg"
print comes out abcd efg
That's generally considered bad practice for precisely this reason.
I agree, but we dont normally have an cleaner option other than:
a) reduce the size of the print message
b) reduce the nesting to give us more space to print ;)
but things get a little more worse now that I think of my personal
experience,
e.g.:
pr_info("%s is not active\n", my_struct->name);
if name is "mpu", then you get a print of:
mpu is not active, and a git grep does not match up either...
c) time required:
$ time git grep "DEBUG option not enabled" .
arch/arm/mach-omap2/smartreflex.c: pr_notice("DEBUG
option not enabled!\n \
arch/arm/mach-omap2/voltage.c: pr_notice("DEBUG option not
enabled!\n \
real 1m34.722s
user 0m0.440s
sys 0m1.820s
Vs cscope or ctags where it is rather instantaneous if you know the
function name..
Interesting, I see better performance than that, especially hot cache,
and of course an educated guess as to where to look helps greatly.
tell me about it.. ;) mebbe I can use this thread to get a machine
upgrade budget :P.. but I guess there are a lot more folks stuck like me..
just for curiosity sake, this data was on a dual core
model name : Intel(R) Pentium(R) 4 CPU 3.40GHz
bogomips : 6800.29
with a 7200RPM SATA 500GB drive :(..
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
