Hi Jacob.
Quick feedback!
You should teach your mailer better manners so it is
visible what you quote and what you answer.
>
> > +static void __init omap3logic_init_irq(void)
> > +{
> > + omap_board_config = omap3logic_config;
> > + omap_board_config_size = ARRAY_SIZE(omap3logic_config);
> > + omap2_init_common_hw(mt46h32m32lf6_sdrc_params,
> > + mt46h32m32lf6_sdrc_params);
> > + omap_init_irq();
> > +#ifdef CONFIG_OMAP_32K_TIMER
> > + omap2_gp_clockevent_set_gptimer(12);
> > +#endif
>
> Fix this on the called site. There is zero reason
> to sprinkle all user of omap2_gp_clockevent_set_gptimer()
> with ifdef/endif.
>
> Will fix
I noticed other users of omap2_gp_clockevent_set_gptimer()
does the same ifdef/endif.
You should take care of them when you have a proper way to do so.
Obviously in another patch.
Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
