> -----Original Message----- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Tuesday, August 24, 2010 3:49 AM > To: Nayak, Rajendra > Cc: linux-omap@vger.kernel.org; Paul Walmsley > Subject: Re: [PATCH 2/5] OMAP2xxx: hwmod: add I2C hwmods for OMAP2420, 2430 > > Rajendra Nayak <rna...@ti.com> writes: > > > From: Paul Walmsley <p...@pwsan.com> > > > > Add hwmod structures for I2C controllers on OMAP2420/2430. > > > > Signed-off-by: Paul Walmsley <p...@pwsan.com> > > Signed-off-by: Rajendra Nayak <rna...@ti.com> > > Cc: Kevin Hilman <khil...@deeprootsystems.com> > > --- > > arch/arm/mach-omap2/omap_hwmod_2420_data.c | 134 > ++++++++++++++++++++++++++- > > arch/arm/mach-omap2/omap_hwmod_2430_data.c | 140 > +++++++++++++++++++++++++++- > > 2 files changed, 270 insertions(+), 4 deletions(-) > > > > [...] > > > +static struct omap_hwmod omap2420_i2c1_hwmod = { > > + .name = "i2c1", > > + .mpu_irqs = i2c1_mpu_irqs, > > + .mpu_irqs_cnt = ARRAY_SIZE(i2c1_mpu_irqs), > > + .sdma_chs = i2c1_sdma_chs, > > + .sdma_chs_cnt = ARRAY_SIZE(i2c1_sdma_chs), > > + .main_clk = "i2c1_fck", > > + .prcm = { > > + .omap2 = { > > + .prcm_reg_id = 1, > > + .module_bit = OMAP2420_EN_I2C1_SHIFT, > > + }, > > + }, > > This needs to be validated on OMAP2. > > I think the enable will fail without the .idlest* fields filled out.
Hi Kevin, I'll make sure I boot test on a N800 before I post the next version of this series. Thanks, Rajendra > > Kevin > > > > + -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
