> -----Original Message----- > From: Cousson, Benoit > Sent: Tuesday, August 24, 2010 3:13 AM > To: Guruswamy, Senthilvadivu > Cc: linux-omap@vger.kernel.org; tomi.valkei...@nokia.com; > p...@pwsan.com; Hilman, Kevin > Subject: Re: [PATCH 15/20] Use platform device to get DSS base addr > > On 8/23/2010 5:58 PM, Guruswamy, Senthilvadivu wrote: > > From: Senthilvadivu Guruswamy<svad...@ti.com> > > [...] > > + struct resource *dss_mem; > > > > - dss.base = ioremap(DSS_BASE, DSS_SZ_REGS); > > + dss_mem = platform_get_resource(dss.pdev, IORESOURCE_MEM, 0); > > platform_get_resource can fail, so you have to check the > returned value. > Please note that this comment applies as well to all the > other patches > from 16 to 19. > [Senthil] Yes, I would incorporate in my next version. > Benoit > > > + dss.base = ioremap(dss_mem->start, resource_size(dss_mem)); > > if (!dss.base) { > > DSSERR("can't ioremap DSS\n"); > > r = -ENOMEM; > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
- [PATCH 14/20] Pass platform_device argum... Guruswamy Senthilvadivu
- [PATCH 15/20] Use platform device to get... Guruswamy Senthilvadivu
- [PATCH 16/20] Get DISPC base addr with p... Guruswamy Senthilvadivu
- [PATCH 17/20] Get VENC base addr from pl... Guruswamy Senthilvadivu
- [PATCH 18/20] Get DSI base addr with pla... Guruswamy Senthilvadivu
- [PATCH 19/20] Get RFBI baseaddr with pla... Guruswamy Senthilvadivu
- [PATCH 20/20] Get DSS IRQ with platform ... Guruswamy Senthilvadivu
- Re: [PATCH 16/20] Get DISPC base addr wi... Tomi Valkeinen
- RE: [PATCH 16/20] Get DISPC base addr wi... Guruswamy, Senthilvadivu
- Re: [PATCH 15/20] Use platform device to... Cousson, Benoit
- RE: [PATCH 15/20] Use platform device to... Guruswamy, Senthilvadivu
- Re: [PATCH 10/20] Move rfbi init to rfbi... Kevin Hilman
- Re: [PATCH 10/20] Move rfbi init to rfbi... Cousson, Benoit
- RE: [PATCH 10/20] Move rfbi init to rfbi... Guruswamy, Senthilvadivu
- Re: [PATCH 10/20] Move rfbi init to rfbi... Cousson, Benoit
- Re: [PATCH 08/20] Replace clk_enable/dis... Kevin Hilman
- Re: [PATCH 05/20] Move dss platform driver t... Tomi Valkeinen
- RE: [PATCH 05/20] Move dss platform driv... Guruswamy, Senthilvadivu
- Re: [PATCH 04/20] Create platform_driver for each... Kevin Hilman
- RE: [PATCH 04/20] Create platform_driver for... Guruswamy, Senthilvadivu
- Re: [PATCH 04/20] Create platform_driver... Kevin Hilman