> -----Original Message-----
> From: Cousson, Benoit 
> Sent: Tuesday, August 24, 2010 3:13 AM
> To: Guruswamy, Senthilvadivu
> Cc: linux-omap@vger.kernel.org; tomi.valkei...@nokia.com; 
> p...@pwsan.com; Hilman, Kevin
> Subject: Re: [PATCH 15/20] Use platform device to get DSS base addr
> 
> On 8/23/2010 5:58 PM, Guruswamy, Senthilvadivu wrote:
> > From: Senthilvadivu Guruswamy<svad...@ti.com>
> >
[...]
> > +   struct resource *dss_mem;
> >
> > -   dss.base = ioremap(DSS_BASE, DSS_SZ_REGS);
> > +   dss_mem = platform_get_resource(dss.pdev, IORESOURCE_MEM, 0);
> 
> platform_get_resource can fail, so you have to check the 
> returned value.
> Please note that this comment applies as well to all the 
> other patches 
> from 16 to 19.
> 
[Senthil]  Yes, I would incorporate in my next version.
> Benoit
> 
> > +   dss.base = ioremap(dss_mem->start, resource_size(dss_mem));
> >     if (!dss.base) {
> >             DSSERR("can't ioremap DSS\n");
> >             r = -ENOMEM;
> 
> --
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to