Kevin,
> -----Original Message-----
> From: Kevin Hilman [mailto:khil...@deeprootsystems.com]
> Sent: Saturday, September 25, 2010 12:07 AM
> To: Varadarajan, Charulatha; Premi, Sanjeev
> Cc: t...@atomide.com; linux-omap@vger.kernel.org; p...@pwsan.com; Cousson,
> Benoit; Nayak, Rajendra; Basak, Partha
> Subject: Re: [PATCH v6 00/13] OMAP: GPIO: Implement GPIO in hwmod way
>
> "Varadarajan, Charulatha" <ch...@ti.com> writes:
>
> Aha. Thanks for digging into this.
>
> Now it makes sense why it worked for SDP and overo, but not omap3evm.
> Relying too much on bootloader settings is definitely a bug in the board
> file. Since we understand it, I am OK if your series breaks this board
> support.
Thanks. Would send the new series of GPIO hwmod patches as per our latest
alignment soon.
>
> > With GPIO hwmod series, gpio module reset happens during init and hence
> > the uboot settings are modified which makes the Ethernet controller to
> fail.
> >
> > Patch [1] below if applied on top of gpio hwmod series would make the
> > evm board work with DHCP and nfsroot.
>
> Indeed, I verified that this method works, although maybe I have an
> older board with a reset line that is not in GPIO1, because setting the
> flag in GPIO1 didn't work. I blindly set it in all the banks, and got
> my board working.
Okay. Something similar must be the reason. Let us get the OMAP3 EVM
Ethernet Controller initialization fixed.
>
> > Rather, patch [2] below would be a better fix for this. I am not
> > getting deeper into the minor details of Ethernet controller
> > initialization for OMAP3 EVM board. This patch would suffice for
> > now. But my observation is that omap3evm_init_smsc911x() needs to be
> > fixed including CS configuration and other required settings for
> > Ethernet controller.
>
> Yes, patch 2 is the better approach (although, I couldn't get it to work
> for me.) I suggest you raise this with Sanjeev and post your patch 2 as
> an RFC to
> the list saying that something like this will be needed after your GPIO
> series. We'll let Sanjeev or someone on his team fix omap3evm support,
> being sure it works for older boards as well.
Posted. See [a]
<<snip>>
> > + /* Configure ethernet controller reset gpio */
> > + if (gpio_request(OMAP3EVM_ETHR_GPIO_RST, "SMSC911x gpio") < 0) {
> > + pr_err(KERN_ERR "Failed to request GPIO8 for smsc911x
> gpio\n");
> > + return;
> > + }
>
> This request has to come before you set the direction and set the value.
My bad :-(
I had sent wrong patch by mistake.
-V Charulatha
[a] https://patchwork.kernel.org/patch/208892/
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
