Felipe Balbi <ba...@ti.com> writes: > On Thu, Oct 21, 2010 at 12:46:11PM -0500, Kevin Hilman wrote: >>Felipe Balbi <ba...@ti.com> writes: >> >>> Trivial patch removing clock framework and adding >>> pm_runtime API. >>> >>> Signed-off-by: Felipe Balbi <ba...@ti.com> >> >>Minor nit: the runtime PM 'put' calls do not need to be the _sync >>versions. You can easily get by using the "normal" (async) versions >>here. > > Will change for next version, was just following what other drivers were > doing.
You're right, I wasn't as picky about this before, but will be going forward. You're the lucky first victim. :) Replacing clk_disable() with put_sync() is the correct functional replacement, since clk_disable is immediate, ans so is put_sync. However, since we have the option of a delayed disable now with runtime PM, I think we should use it. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
