>>>Thara Gopinath <th...@ti.com> writes:
>>>
>>>> +           if (ret) {
>>>
>>>                         goto error;
>>>
>>>> +                   struct resource *mem;
>>>> +
>>>> +                   iounmap(sr_info->base);
>>>> +                   mem = platform_get_resource(sr_info->pdev,
>>>> +                           IORESOURCE_MEM, 0);
>>>> +                   release_mem_region(mem->start, resource_size(mem));
>>>> +                   list_del(&sr_info->node);
>>>> +                   dev_err(&sr_info->pdev->dev, "%s: ERROR in registering"
>>>> +                           "interrupt handler. Smartreflex will"
>>>> +                           "not function as desired\n", __func__);
>>>> +
>>>> +                   kfree(sr_info);
>>>> +                   return ret;
>>>> +           }
>>>
>>>and move this after the return...
>
> I did not understand this comment.

I guess he meant to move error handling to the end of function, and
jump there with goto.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to