Manju

On Sat, 4 Dec 2010, G, Manjunath Kondaiah wrote:

> Add OMAP2420 DMA hwmod data and also add required
> DMA device attributes.
> 
> Signed-off-by: G, Manjunath Kondaiah <manj...@ti.com>
> Cc: Benoit Cousson <b-cous...@ti.com>
> Cc: Kevin Hilman <khil...@deeprootsystems.com>
> Cc: Santosh Shilimkar <santosh.shilim...@ti.com>
>
> +/* dma_system -> L3 */
> +static struct omap_hwmod_ocp_if omap2420_dma_system__l3 = {
> +     .master         = &omap2420_dma_system_hwmod,
> +     .slave          = &omap2420_l3_main_hwmod,
> +     .clk            = "l3_div_ck",

This clock does not exist on OMAP2420.  Did you test this patch on 2420?

> +/* l4_cfg -> dma_system */
> +static struct omap_hwmod_ocp_if omap2420_l4_core__dma_system = {
> +     .master         = &omap2420_l4_core_hwmod,
> +     .slave          = &omap2420_dma_system_hwmod,
> +     .clk            = "l4_div_ck",

Nor does this clock exist on OMAP2420.

> +static struct omap_hwmod omap2420_dma_system_hwmod = {
> +     .name           = "dma",
> +     .class          = &omap2420_dma_hwmod_class,
> +     .mpu_irqs       = omap2420_dma_system_irqs,
> +     .mpu_irqs_cnt   = ARRAY_SIZE(omap2420_dma_system_irqs),
> +     .main_clk       = "l3_div_ck",

And neither does this one.

Please fix these and test on OMAP2420 before sending the fixed patches.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to