On Wed, 2010-12-22 at 16:55 +0530, ext Guruswamy, Senthilvadivu wrote: > > > -----Original Message----- > > From: Tomi Valkeinen [mailto:tomi.valkei...@nokia.com] > > Sent: Tuesday, December 21, 2010 7:19 PM > > To: Guruswamy, Senthilvadivu > > Cc: khil...@deeprootsystems.com; p...@pwsan.com; Hiremath, Vaibhav; linux- > > o...@vger.kernel.org > > Subject: Re: [PATCH v2 05/17] OMAP2,3 DSS Driver register moved to > > mach_omap2 > > > > On Mon, 2010-11-29 at 17:21 +0530, ext Guruswamy Senthilvadivu wrote: > > > From: Senthilvadivu Guruswamy <svad...@ti.com> > > > > > > Move DSS driver register from board file to devices.c > > > Changed device name from omapdss to omap_display as the > > > driver takes care of panel information. > > > > Here you do two separate things, adding the omap_display_init() and > > changing the driver name. The latter should be in the previous patch, I > > suppose. > [Senthil] Yes, I can change the driver name first and then > omap_display_init() as 2 small patches. When I do this I have to do > similarly for board files too. Then the board file related changes alone > would be 3 separate patches - 1. driver name change, 2. omap_display_init, > 3. Regulator initialization being done with driver name > > If this is fine, then I can send v3 version of the patch set.
Try to do one logical change in one patch, so for example when you change the driver name, change it in the clock files, board files and in the driver. That way the kernel stays whole after each patch. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
