> -----Original Message----- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Saturday, January 08, 2011 2:44 AM > To: Santosh Shilimkar > Cc: linux-omap@vger.kernel.org; t...@atomide.com; linux-arm- > ker...@lists.infradead.org; Paul Walmsley > Subject: Re: [PATCH v2 2/5] omap2plus: prm: Trvial build break fix > for undefined reference to 'omap2_prm_read_mod_reg' > > Santosh Shilimkar <santosh.shilim...@ti.com> writes: > > [...] > > >> I think it would be best to use WARN() on these, rather than > >> WARN_ONCE(). That's because these could be called from different > >> parts of the code base, and the stack backtrace will help someone > >> figure out all the code that needs to be fixed. > >> > >> Once you do that, this patch is > >> > >> Acked-by: Paul Walmsley <p...@pwsan.com> > >> > > > With WARN() instead of WARN_ONCE() and Paul's ack, here > > is an updated patch. > > Thanks, will queue for .38-rc cycle. > > I'll again plead for working on your git-send-email setup. It looks > like your using outlook. The inline patch is wrapped (as outlook > almost > always does.) The attached version applied fine, but the strong > preference is for a single inline patch. > Its google mail now a days. I thought it will wrap and hence attached the version.
Fully agree with inline patch but as this one was minor update I skipped it. Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
