Jean, > -----Original Message----- > From: Jean Pihet [mailto:jean.pi...@newoldbits.com] > Sent: Monday, February 07, 2011 9:36 PM > To: Santosh Shilimkar; Tony Lindgren > Cc: Thomas Renninger; linux-omap@vger.kernel.org; Jean Pihet-XID > Subject: Re: [PATCH] perf: add OMAP support for the new power events > > Hi Santosh, Tony, > > On Wed, Jan 26, 2011 at 11:06 AM, Santosh Shilimkar > <santosh.shilim...@ti.com> wrote: > >> -----Original Message----- > >> From: Jean Pihet [mailto:jean.pi...@newoldbits.com] > >> Sent: Wednesday, January 26, 2011 3:20 PM > >> To: Santosh Shilimkar > >> Cc: Thomas Renninger; linux-omap@vger.kernel.org; Jean Pihet-XID > >> Subject: Re: [PATCH] perf: add OMAP support for the new power > events > >> > > [...] > > > >> > We need to track the actual power domain transitions as well > >> > at hardware level. > >> Agree > >> > >> > Can you please look at "pwrdm_pre_transition()" and > >> > "pwrdm_post_transition()" > >> > This code keep track of it using the next power state > >> > and prev-power state. > >> The current API only has 'trace_power_domain_target' which tracks > >> the > >> desired target state. > >> I think we need an extra tracer 'trace_power_domain_hitstate' so > >> that > >> the trace parser can compare the desired ('target') and actually > hit > >> ('hitstate') states. > >> > > We use next state and previous state. 'hitstate' doesn't sound > > well that's really secondary. > > > > Do you plan to add that additional trace then ? > Yes that is idea, although adding new events in the power trace API > has been proved as quite difficult to get accepted. In any case this > will be done separately (iow it is not part of this patch). > > Also this patch also supports OMAP4 since the changes are in the > generic PM frameworks. Thanks to the OMAP PM arch guys ;p > > Is the patch OK? If so can it be queued in the l-o tree? > I just looked at from the current need of DEBUG counters and commented what needs to be supported.
Am ok with the patch, but that means we still need to keep using and supporting PM debug counters till we support the additional trace events. May be Kevin/Paul can take a call on this. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
