Nishanth Menon <n...@ti.com> writes: > SmartReflex IP v1 and v2 have different registers and offsets. > Currently, we pass the status as is to the class driver. However, > since we dont pass the version of the underlying SR hardware > to the Class driver, it will not be unable to make consistent > sense of the status bits coming over to it. > > A class driver should be able to function without dependency > on the exact IP version it is actually running on. We hence > introduce our own translation in s/w level for a generic > notification flag. > > As part of this change, we will now call the notifier iff we get > a match with the notifier flags that the class driver requested. > > Signed-off-by: Nishanth Menon <n...@ti.com>
Looks fine, minor comment below... [...] > diff --git a/arch/arm/plat-omap/include/plat/smartreflex.h > b/arch/arm/plat-omap/include/plat/smartreflex.h > index 8b6ecd9..ff07d1e 100644 > --- a/arch/arm/plat-omap/include/plat/smartreflex.h > +++ b/arch/arm/plat-omap/include/plat/smartreflex.h > @@ -141,6 +141,12 @@ > #define OMAP3430_SR_ERRWEIGHT 0x04 > #define OMAP3430_SR_ERRMAXLIMIT 0x02 > > +/* Smart reflex notifiers for class drivers to use */ > +#define SR_NOTIFY_MCUACCUM (0x1 << 0) > +#define SR_NOTIFY_MCUVALID (0x1 << 1) > +#define SR_NOTIFY_MCUBOUND (0x1 << 2) > +#define SR_NOTIFY_MCUDISACK (0x1 << 3) > + Please use BIT(x) Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
