Hi,

Few comments on the .dts data layout below.

* G, Manjunath Kondaiah <manj...@ti.com> [110630 02:44]:
> --- a/arch/arm/boot/dts/omap3-beagle-nunchuck.dts
> +++ b/arch/arm/boot/dts/omap3-beagle-nunchuck.dts
> @@ -2,11 +2,6 @@
>  
>  / {
>       i2c@48072000 {
> -             compatible = "ti,omap3-i2c";
> -             reg = <0x48072000 0x80>;
> -             #address-cells = <1>;
> -             #size-cells = <0>;
> -
>               eeprom@50 {
>                       compatible = "at,at24c01";
>                       reg = < 0x50 >;

The board .dts file should include the omap3 SoC .dts file.

The omap3 SoC .dts file should have the devices mapped to L3 and L4
busses, and the then i2c@1 would just contain the bus offset.

Then the i2c@1 entry would be repeated in the board specific
.dts and tell that the i2c@1 is enabled.

> --- a/arch/arm/boot/dts/omap3-beagle.dts
> +++ b/arch/arm/boot/dts/omap3-beagle.dts
> @@ -4,4 +4,46 @@
>  / {
>       model = "TI OMAP3 BeagleBoard";
>       compatible = "ti,omap3-beagle";
> +     interrupt-parent = <&gic>;
> +
> +     gic: interrupt-controller@48241000 {
> +             compatible = "ti,omap-gic", "arm,gic";
> +             interrupt-controller;
> +             #interrupt-cells = <1>;
> +             reg = <0x48200000 0x1000>;
> +     };

There's no GIC on omap3, that's only on Cortex A9 systems.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to