Hi, On Wed, Aug 10, 2011 at 05:41:02AM -0700, Tony Lindgren wrote: > * Felipe Balbi <ba...@ti.com> [110810 05:31]: > > > > On Wed, Aug 10, 2011 at 05:55:20PM +0530, Keerthy wrote: > > > + > > > +int __init omap_devinit_temp_sensor(void) > > > +{ > > > + if (!cpu_is_omap446x()) > > > + return 0; > > > + > > > + return omap_hwmod_for_each_by_class("temperature_sensor", > > > + temp_sensor_dev_init, NULL); > > > +} > > > + > > > +arch_initcall(omap_devinit_temp_sensor); > > > > I really dislike people adding more and more *initcall() to their pieces > > of code. But Tony is the final Judge. > > Yes how about making this just a regular device driver and have it > live under drivers/ somewhere? > > Or is there some reason why this could not be a loadable module?
driver is loadable, this is just creating the platform_device, but still I don't think it deserves its own arch_initcall(), it could very well be something which is called after we know we're running at omap4, or called by each board... -- balbi
signature.asc
Description: Digital signature