Hi, On Tue, Sep 06, 2011 at 12:30:15PM +0530, Gupta, Ajay Kumar wrote: > > > diff --git a/drivers/usb/musb/musb_core.c > > > b/drivers/usb/musb/musb_core.c index 20a2873..07f3faf 100644 > > > --- a/drivers/usb/musb/musb_core.c > > > +++ b/drivers/usb/musb/musb_core.c > > > @@ -1014,7 +1014,9 @@ static void musb_shutdown(struct > > platform_device *pdev) > > > || defined(CONFIG_USB_MUSB_OMAP2PLUS) \ > > > || defined(CONFIG_USB_MUSB_OMAP2PLUS_MODULE) \ > > > || defined(CONFIG_USB_MUSB_AM35X) \ > > > - || defined(CONFIG_USB_MUSB_AM35X_MODULE) > > > + || defined(CONFIG_USB_MUSB_AM35X_MODULE) \ > > > + || defined(CONFIG_USB_MUSB_TI81XX) \ > > > + || defined(CONFIG_USB_MUSB_TI81XX_MODULE) > > > > we really need to find a better way to handle this :-( > > We use to have 'fifo_mode' within 'struct musb_platform_ops' so shouldn't > It be brought back to fix this?
no. I don't think that's a good idea. The best way would be for gadget to tell us about all endpoints it will use in one go. Something like usb_ep_request_array() (to match the gpio_request_array), with that, we could allocate FIFO space based on how many endpoints will be used, in fact. But that's something for the future, for now the ifdef is the only way :-( -- balbi
signature.asc
Description: Digital signature
