Hello.

On 02-12-2011 13:12, Ming Lei wrote:

Signed-off-by: Ming Lei<ming....@canonical.com>
---
  arch/arm/mach-omap2/devices.c |   33 +++++++++++++++++++++++++++++++++
  1 files changed, 33 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 1166bdc..a392af5 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -728,6 +728,38 @@ void __init omap242x_init_mmc(struct 
omap_mmc_platform_data **mmc_data)

  #endif

+static struct platform_device* __init omap4_init_fdif(void)

   Shouldn't there be space before *? checkpatch.pl is silent about it?
ALso, I'd have placed '__init' after 'static'...

+{
+       int id = -1;
+       struct platform_device *pd;
+       struct omap_hwmod *oh;
+       const char *dev_name = "fdif";

   Why you need this variable at all?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to