* Rusty Russell <[email protected]> [120213 16:07]: > On Mon, 13 Feb 2012 22:51:18 +0000, Russell King - ARM Linux > <[email protected]> wrote: > > On Mon, Feb 13, 2012 at 11:26:52PM +0100, Uwe Kleine-König wrote: > > > On Mon, Feb 13, 2012 at 01:24:01PM -0800, Tony Lindgren wrote: > > > Maybe: > > > > > > #ifndef R_ARM_CALL > > > #warning "you're elf.h include is outdated" > > > > "You are elf.h include is outdated" does not make sense. > > > > Why are you calling Tony an elf.h include? > > Because he knew it would attract the attention of pedants to the patch? > :)
I've been called worse than that :) > Just do the #ifndef, and skip the warning. There's not much the poor > user receiving the warning can do about it. OK > Acked-by: Rusty Russell <[email protected]> Assuming your ack applies for this patch below, let me know if that's not the case. Regards, Tony From: Tony Lindgren <[email protected]> Date: Mon, 13 Feb 2012 12:30:09 -0800 Subject: [PATCH] modpost: Fix section warnings for ARM for many compilers It turns out that many compilers don't show section warnings on ARM currently because handling for ARM_CALL relocs are missing from modpost.c. Based on commit c2e26114 ([ARM] 3205/1: Handle new EABI relocations when loading kernel modules) it seems that R_ARM_PC24, R_ARM_CALL and R_ARM_JUMP24 can be handled the same way. Note that at least Debian libc6-dev is missing defines for both R_ARM_CALL and R_ARM_JUMP24 in /usr/include/elf.h. So for now we need to define them in modpost.c if not defined. Acked-by: Rusty Russell <[email protected]> Cc: Ben Hutchings <[email protected]> Cc: Anders Kaseorg <[email protected]> Cc: Greg KH <[email protected]> Cc: Russell King <[email protected]> Signed-off-by: Tony Lindgren <[email protected]> --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1494,6 +1494,13 @@ static int addend_386_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r) return 0; } +#ifndef R_ARM_CALL +#define R_ARM_CALL 28 +#endif +#ifndef R_ARM_JUMP24 +#define R_ARM_JUMP24 29 +#endif + static int addend_arm_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r) { unsigned int r_typ = ELF_R_TYPE(r->r_info); @@ -1505,6 +1512,8 @@ static int addend_arm_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r) (elf->symtab_start + ELF_R_SYM(r->r_info)); break; case R_ARM_PC24: + case R_ARM_CALL: + case R_ARM_JUMP24: /* From ARM ABI: ((S + A) | T) - P */ r->r_addend = (int)(long)(elf->hdr + sechdr->sh_offset + -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
