On Thu, Feb 23, 2012 at 05:40:30PM +0530, Tarun Kanti DebBarma wrote:
> The GPIO trigger parameter is of type unsigned.
> enum {
> IRQ_TYPE_NONE = 0x00000000,
> IRQ_TYPE_EDGE_RISING = 0x00000001,
> IRQ_TYPE_EDGE_FALLING = 0x00000002,
> IRQ_TYPE_EDGE_BOTH = (IRQ_TYPE_EDGE_FALLING |
> IRQ_TYPE_EDGE_RISING),
> IRQ_TYPE_LEVEL_HIGH = 0x00000004,
> IRQ_TYPE_LEVEL_LOW = 0x00000008,
> IRQ_TYPE_LEVEL_MASK = (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH),
> IRQ_TYPE_SENSE_MASK = 0x0000000f,
>
> IRQ_TYPE_PROBE = 0x00000010,
> ...
> };
> Even though gpio_irq_type(struct irq_data *d, unsigned type) has the right
> type
> of parameter, the subsequent called functions set_gpio_triggering() and
> set_gpio_trigger() wrongly makes it signed integer. Fix this.
>
> Signed-off-by: Tarun Kanti DebBarma <tarun.ka...@ti.com>Cool, I guess sparse would also have caught that error :-) Acked-by: Felipe Balbi <ba...@ti.com> -- balbi
signature.asc
Description: Digital signature
