On Tuesday 28 February 2012, Ohad Ben-Cohen wrote:
> On Tue, Feb 28, 2012 at 11:02 AM, Russell King - ARM Linux
> <li...@arm.linux.org.uk> wrote:
> > 1. It selects OMAP_IOMMU which may not have its dependencies satisfied.
> 
> I'll select IOMMU_SUPPORT too (I prefer selecting here rather than
> depending, because users may have hard time realizing they need to
> enable omap's iommu first in order for omap's remoteproc option to
> show up).

I think 'depends' would be better here, because selecting IOMMU_SUPPORT
has other side-effects that a user might not want. It's just as likely
that someone wants to disable IOMMU_SUPPORT and needs to find OMAP_REMOTEPROC
as wanting to enable OMAP_REMOTEPROC and having to find IOMMU_SUPPORT.

In most cases, the defconfig should just set both.

> > 2. It's a new feature.  It is experimental.  It should not default to 'm'
> 
> I'll set it to 'n' (by removing that line altogether).

ok.

        Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to